-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Dependency Upgrade #6387
ui: Dependency Upgrade #6387
Conversation
@@ -1,3 +1,6 @@ | |||
/*eslint ember/require-return-from-computed: "warn"*/ | |||
// TODO: Remove ^ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you want to address these later but I think this one would be as simple as an else { return undefined; }
I can follow up with you on the |
@alvin-huang ah thanks for looking, thats cool then if it all looks good to you, I added a commit on the end here, everything continues to pass 🎉 , thankyou! |
Closing in favour of #6452 |
This PR is ontop of our ember update to 3.8 and upgrades everything else (apart from ember-exam)
Interesting things of note:
dart-sass
which we weren't using but was left in there from an experiment from many moons ago 😮 !jquery
resolution is no longer needed, the upgrade pushes us into 3.4 (plus we hope to remove jquery entirely soon)We've left
ember-exam
without upgrading here potentially @alvin-huang might want to do that, or at least I need to check with him that the upgrade will be good for CI - probably to be done in a later PR.