Set MinQuorum variable in Autopilot #6654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schristoff
commented
Oct 20, 2019
schristoff
force-pushed
the
5922-expected-peers
branch
from
878e33e to
e653583
Compare
mikemorris
approved these changes
Oct 25, 2019
freddygv
reviewed
Oct 25, 2019
freddygv
reviewed
Oct 26, 2019
kaitlincart
reviewed
Oct 28, 2019
kaitlincart
reviewed
Oct 28, 2019
kaitlincart
reviewed
Oct 28, 2019
| @@ -782,6 +782,9 @@ default will automatically work with some tooling. | |||
| the maximum number of log entries that a server can trail the leader by before being considered unhealthy. Defaults | |||
| to 250. | |||
|
|
|||
| * <a name="min_quorum"></a><a href="#min_quorum">`min_quorum`</a> - Sets the minimum number of servers allowed in a cluster | |||
There was a problem hiding this comment.
Allowed doesn't quite fit, maybe again use "needed" or "necessary". Is cluster the right term? Also is there a default? If there isn't a default, then you can say so.
There was a problem hiding this comment.
This sound better?
Sets the minimum number of servers necessary in a cluster
before autopilot can prune dead servers. There is no default.
There was a problem hiding this comment.
I don't know the proper way to say there isn't a default, but I appreciate the "necessary" wording suggestion. It sounds way more clear then "allowed"
Co-Authored-By: kaitlincarter-hc <43049322+kaitlincarter-hc@users.noreply.github.com>
Co-Authored-By: kaitlincarter-hc <43049322+kaitlincarter-hc@users.noreply.github.com>
schristoff
added a commit
that referenced
this pull request
Oct 29, 2019
* Add MinQuorum to Autopilot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5922
MinQuorumallows users to pass in the number of servers needed in a cluster before pruning of dead servers in autopilot can occur.