Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Namespace support to the API module and the CLI commands #6874

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Add Namespace support to the API module and the CLI commands #6874

merged 1 commit into from
Dec 6, 2019

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Dec 3, 2019

Also update the Docs and fixup the HTTP API to return proper errors when someone attempts to use Namespaces with an OSS agent.

@mkeeler mkeeler added this to the 1.7.0 milestone Dec 3, 2019
@mkeeler mkeeler requested a review from a team December 3, 2019 19:35
@mkeeler mkeeler force-pushed the sync/namespace-api-and-docs branch from dbccdf3 to a057a94 Compare December 3, 2019 19:46
@mkeeler mkeeler requested a review from kaitlincart December 3, 2019 19:55
@codecov
Copy link

codecov bot commented Dec 3, 2019 •
edited
Loading

Codecov Report

Merging #6874 into master will decrease coverage by 0.16%.
The diff coverage is 36.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6874      +/-   ##
==========================================
- Coverage   65.92%   65.75%   -0.17%     
==========================================
  Files         436      435       -1     
  Lines       52631    52572      -59     
==========================================
- Hits        34695    34570     -125     
- Misses      13798    13832      +34     
- Partials     4138     4170      +32
Impacted Files Coverage Δ
command/logout/logout.go 64.28% <ø> (ø) ⬆️
api/acl.go 33.99% <ø> (ø) ⬆️
agent/structs/structs.go 52.4% <0%> (-0.16%) ⬇️
command/flags/http.go 4.49% <0%> (-0.22%) ⬇️
agent/structs/acl.go 33.48% <0%> (+0.54%) ⬆️
agent/kvs_endpoint.go 80.25% <0%> (+0.12%) ⬆️
agent/session_endpoint.go 58.97% <0%> (-9.21%) ⬇️
command/acl/policy/delete/policy_delete.go 57.14% <100%> (+1.04%) ⬆️
command/acl/authmethod/list/authmethod_list.go 72.22% <100%> (+0.79%) ⬆️
command/acl/bindingrule/read/bindingrule_read.go 73.58% <100%> (+0.5%) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb91f3...089af39. Read the comment docs.

@mkeeler mkeeler force-pushed the sync/namespace-api-and-docs branch 2 times, most recently from acc0bca to 39d1eaf Compare December 4, 2019 19:13
@mkeeler mkeeler force-pushed the sync/namespace-api-and-docs branch from d52944b to b38c7a7 Compare December 5, 2019 15:18
hanshasselberg
hanshasselberg reviewed Dec 6, 2019
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left a couple small comments.

agent/http_oss.go Show resolved Hide resolved
agent/http_oss.go Outdated Show resolved Hide resolved
api/acl.go Outdated Show resolved Hide resolved
command/acl/token/clone/token_clone_test.go Show resolved Hide resolved
website/source/layouts/docs.erb Show resolved Hide resolved
@mkeeler mkeeler force-pushed the sync/namespace-api-and-docs branch from 072ea76 to 120580d Compare December 6, 2019 15:38
@mkeeler
Add Namespace support to the API module and the CLI commands
089af39 
Also update the Docs and fixup the HTTP API to return proper errors when someone attempts to use Namespaces with an OSS agent.

Add Namespace HTTP API docs

Make all API endpoints disallow unknown fields
@mkeeler mkeeler force-pushed the sync/namespace-api-and-docs branch from 120580d to 089af39 Compare December 6, 2019 15:42
hanshasselberg
hanshasselberg approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mkeeler
Copy link
Member Author

mkeeler commented Dec 6, 2019

Flaky API test was in CI. Going to merge anyways.

@mkeeler mkeeler merged commit a704ebe into master Dec 6, 2019
@mkeeler mkeeler deleted the sync/namespace-api-and-docs branch December 6, 2019 16:14
This was referenced Dec 10, 2019
Merged
Merged
@ghost
Copy link

ghost commented Jan 25, 2020

Hey there,

This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days.

If you are still experiencing problems, or still have questions, feel free to open a new one 👍.

@ghost ghost locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaitlincart kaitlincart kaitlincart left review comments

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mkeeler @hanshasselberg @kaitlincart