-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Use base fonts throughout the app #6881
Conversation
6830f7c
to
3e381a7
Compare
347b3b6
to
5850ff2
Compare
Codecov Report
@@ Coverage Diff @@
## ui-staging #6881 +/- ##
=============================================
- Coverage 65.63% 65.6% -0.03%
=============================================
Files 443 443
Lines 53292 53292
=============================================
- Hits 34977 34964 -13
- Misses 14096 14108 +12
- Partials 4219 4220 +1
Continue to review full report at Codecov.
|
We've had a set of %placeholders in our base styles for quite a while but not butten the bullet to use them. This begins to use them. We had to make a small amount of tweaks to base whilst doing this, but its as we'd prefer there to be as few font placeholders as possible. We might/should be able to reduce these further at somepoint, or potentially rename them. We currently have six header fonts (or 4 header fonts/2 strong body fonts) and 3 body fonts. We also noticed an empty CSS file and deleted that while we were here. We also noticed that the bottom border of structure tabs was a pixel larger than ours so we tweaked that here also.
5850ff2
to
8fdde95
Compare
We've had a set of %placeholders in our base styles for quite a while but not butten the bullet to use them. This begins to use them. We had to make a small amount of tweaks to base whilst doing this, but its as we'd prefer there to be as few font placeholders as possible. We might/should be able to reduce these further at somepoint, or potentially rename them. We currently have six header fonts (or 4 header fonts/2 strong body fonts) and 3 body fonts. We also noticed an empty CSS file and deleted that while we were here. We also noticed that the bottom border of structure tabs was a pixel larger than ours so we tweaked that here also.
We've had a set of %placeholders in our base styles for quite a while but not butten the bullet to use them. This begins to use them. We had to make a small amount of tweaks to base whilst doing this, but its as we'd prefer there to be as few font placeholders as possible. We might/should be able to reduce these further at somepoint, or potentially rename them. We currently have six header fonts (or 4 header fonts/2 strong body fonts) and 3 body fonts. We also noticed an empty CSS file and deleted that while we were here. We also noticed that the bottom border of structure tabs was a pixel larger than ours so we tweaked that here also.
Hey there, This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days. If you are still experiencing problems, or still have questions, feel free to open a new one 👍. |
We've had a set of font
%placeholders
in our base styles for quite a whilebut not bitten the bullet to use them. This begins to use them.
We had to make a small amount of tweaks to base whilst doing this, but
its as we'd prefer there to be as few font placeholders as possible. We
might/should be able to reduce these further at somepoint, or
potentially rename them. We currently have six header fonts (or 4 header
fonts/2 strong body fonts) and 3 body fonts.
We also noticed an empty CSS file and deleted that while we were here.
We also noticed that the bottom border of structure tabs was a pixel
larger than ours so we tweaked that here also.
Moving forwards we are likely to make some tweaks to our
base
filesto bring the 100% into line with structure. Our app
typography.scss
fileis now much smaller/saner.
Preview link.
Further down the line we are considering moving a lot of this into a
component/component-name/typography.scss
file (so similar to thelayout.scss/skin.scss
files). We've quibbledabout doing this for a while as generally you want fonts to cascade/be
configured from the outside as much as possible and not have the component
itself dictate font sizes. If we do move any of this to the component specific file,
we'll probably make it optional so you still have the option of doing it at a project
level.