Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Fixes styling of 'duplicate intention' error message #6936

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

johncowen
Copy link
Contributor

During #5033 tweaked the possible classes for our notifications. The where all either success or error, apart from one, which we didn't realize for when you try to save an intention that already exists.

This makes 'exists' notifications like error ones.

Previous:

Screenshot 2019-12-11 at 15 00 33

Fixed:

Screenshot 2019-12-11 at 15 01 51

At some point after our data-source work lands we are likely to re-visit this as less of the UI will use a Route.model blocking page load approach, so we added some comments here to that effect.

@johncowen johncowen requested a review from a team December 11, 2019 15:06
@johncowen johncowen added the theme/ui Anything related to the UI label Dec 11, 2019
@johncowen johncowen force-pushed the bugfix/ui-intention-duplicate-styling branch from 03d2654 to 02de845 Compare December 12, 2019 13:29
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #6936 into ui-staging will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           ui-staging    #6936      +/-   ##
==============================================
- Coverage       65.66%   65.65%   -0.01%     
==============================================
  Files             443      443              
  Lines           53312    53312              
==============================================
- Hits            35006    35004       -2     
- Misses          14086    14093       +7     
+ Partials         4220     4215       -5
Impacted Files Coverage Δ
command/monitor/monitor.go 52% <0%> (-4%) ⬇️
agent/consul/operator_autopilot_endpoint.go 46% <0%> (-4%) ⬇️
agent/consul/session_ttl.go 85.48% <0%> (-3.23%) ⬇️
agent/consul/replication.go 85.71% <0%> (-2.39%) ⬇️
agent/consul/config_replication.go 75.51% <0%> (-2.05%) ⬇️
agent/consul/rpc.go 78.57% <0%> (-0.76%) ⬇️
agent/local/state.go 77.08% <0%> (-0.49%) ⬇️
agent/consul/leader.go 69.61% <0%> (-0.39%) ⬇️
agent/config/builder.go 83.21% <0%> (-0.09%) ⬇️
agent/service_manager.go 82.47% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b330b80...0e65120. Read the comment docs.

@johncowen johncowen added this to the 1.7.0 milestone Dec 16, 2019
@johncowen johncowen added the type/bug Feature does not function as expected label Dec 16, 2019
@johncowen johncowen removed this from the 1.7.0 milestone Dec 17, 2019
@johncowen johncowen force-pushed the bugfix/ui-intention-duplicate-styling branch from 02de845 to 0e65120 Compare December 17, 2019 15:58
@johncowen johncowen merged commit a2e773e into ui-staging Dec 17, 2019
@johncowen johncowen deleted the bugfix/ui-intention-duplicate-styling branch December 17, 2019 16:17
@ghost
Copy link

ghost commented Jan 25, 2020

Hey there,

This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days.

If you are still experiencing problems, or still have questions, feel free to open a new one 👍.

@ghost ghost locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/ui Anything related to the UI type/bug Feature does not function as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants