Add egress rule to SG for TF 0.5 compat #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See "NOTE on Egress rules" here http://www.terraform.io/docs/providers/aws/r/security_group.html As reported here: hashicorp/terraform#1873
armon
added a commit
that referenced
this pull request
May 8, 2015
Add egress rule to SG for TF 0.5 compat
|
LGTM! |
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
With the introduction of tproxy, the errors when a connection fail include the KubeDNS names, for example: ``` curl: (7) Failed to connect to test-er1l1u-consul-ingress-gateway.default port 8080: Connection refused ``` Rather than match on the name it's connecting to, we can instead rely on the "curl: (7) Failed to connect" part of the string since error code 7 is always a connection refused error and that's all we're really testing. This is the specific test that was failing: https://app.circleci.com/pipelines/github/hashicorp/consul-helm/2850/workflows/f145253b-2068-47d4-a427-b1ad7be6275c/jobs/11011. I think it only passed before because it must have been getting "curl: (52) Empty reply from server".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See "NOTE on Egress rules" here http://www.terraform.io/docs/providers/aws/r/security_group.html
As reported here: hashicorp/terraform#1873