terraform/aws module: typo #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what I get for thinking that the GitHub in-browser editor would be sufficient. -_-
|
Don't worry, I actually tested the plan locally this time. 🙈 |
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
Prior to apiextensions.k8s.io/v1, structured schema was optional for CRD spec, but now it is required. Since config field can have arbitrary keys, we need to tell Kubernetes to allow that explicitly now that we've upgraded from v1beta1 to v1. * Update CRD schema for ProxyDefaults based on new generated code from hashicorp/consul-k8s#495 * Update acceptance test for proxy defaults to set all possible fields. For the config field, we're not setting all acceptable values but I think it's OK since we're trying to check that at least one is accepted by Consul.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I get for thinking that the GitHub in-browser editor would
be sufficient. -_-