Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include DC in the members command output #946

Merged
merged 1 commit into from
May 15, 2015
Merged

Include DC in the members command output #946

merged 1 commit into from
May 15, 2015

Conversation

tgwizard
Copy link
Contributor

Fixes #942. Should I add more detailed tests?

armon added a commit that referenced this pull request May 15, 2015
Include DC in the members command output
@armon armon merged commit 0e1fb28 into hashicorp:master May 15, 2015
@armon
Copy link
Member

armon commented May 15, 2015

LGTM! Thanks!

@c4milo
Copy link
Contributor

c4milo commented May 16, 2015

@tgwizard I think we could also remove the datacenter from the node name when listing WAN members, now that we have a column dedicated to that.

@tgwizard
Copy link
Contributor Author

Hmm, @c4milo I don't think that is the datacenter but part of the actual node name. If I run it locally I get

↳ $ consul members
Node                     Address             Status  Type    Build  Protocol  DC
Adams-MacBook-Pro.local  192.168.1.148:8301  alive   server  0.5.1  2         dc1

@tgwizard tgwizard deleted the include-dc-in-members-output branch May 16, 2015 10:22
@c4milo
Copy link
Contributor

c4milo commented May 16, 2015

-wan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Include datacenter in consul members output.
3 participants