Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add filtered by in Nodes, KV and Intentions #9497

Merged

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jan 5, 2021

This continues on from #9442 (which is the base branch for this PR), by adding the 'Filtered by' functionality to Nodes, KVs and Intentions (the top level, non-restricted areas), plus per service Intentions.

Additional notes:

  1. Moved a top level i18n key: component > components to mirror the ember components directory.
  2. Exported the generic search and menu components from the SearchBar component and used those for if we need to switch this up slightly at some point.
  3. Moved a few model hooks to async (only was is actually async)

Apart from that its mainly 'copy/pasta, tweak, tweak, tweak' three times.

@johncowen johncowen added theme/ui Anything related to the UI backport/1.9 labels Jan 5, 2021
@johncowen johncowen requested a review from kaxcode January 5, 2021 14:34
@johncowen johncowen marked this pull request as ready for review January 5, 2021 14:34
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@johncowen
Copy link
Contributor Author

Note to potential future self: This is going down onto a branch that will be eventually backported, so I removed the backport label here.

@johncowen johncowen merged commit b403abe into ui/feature/services-filter-by Jan 19, 2021
@johncowen johncowen deleted the ui/feature/top-level-filter-by branch January 19, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants