-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Add filtered by in Nodes, KV and Intentions #9497
Merged
johncowen
merged 11 commits into
ui/feature/services-filter-by
from
ui/feature/top-level-filter-by
Jan 19, 2021
Merged
ui: Add filtered by in Nodes, KV and Intentions #9497
johncowen
merged 11 commits into
ui/feature/services-filter-by
from
ui/feature/top-level-filter-by
Jan 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
kaxcode
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Note to potential future self: This is going down onto a branch that will be eventually backported, so I removed the backport label here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues on from #9442 (which is the base branch for this PR), by adding the 'Filtered by' functionality to Nodes, KVs and Intentions (the top level, non-restricted areas), plus per service Intentions.
Additional notes:
component
>components
to mirror the embercomponents
directory.model
hooks toasync
(only was is actually async)Apart from that its mainly 'copy/pasta, tweak, tweak, tweak' three times.