ui: Fix 'filter by' removal and provide more tests/docs around it #9608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when removing a special 'searchproperty' filter, it would remove all the search property filters instead of only the one you had clicked. This fixes that up, adds tests and adds copious amounts of documentation around the filter data reshaping function for future self/somebody
johncowen
changed the title
6 tasks
johncowen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #9442 and the base branch of this is that PR.
Previously when removing a special 'searchproperty' filter, it would
remove all the search property filters instead of only the one you had
clicked.
This fixes that up, adds unit tests and adds copious amounts of documentation
around the filter data reshaping function for future self/somebody.