Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add 'filtered by' to Upstreams and UpstreamInstance listings #9632

Merged
merged 5 commits into from
Jan 25, 2021

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jan 25, 2021

This continues on from #9442 (which is the base branch for this PR), by adding the 'Filtered by' functionality to Upstreams, Linked Services and Upstream Instances tabs (remaining sub Service/Service Instance tabs)

Additionally, I noticed our filter for Services with no healthchecks at all was not configured, so I added that on the end here.

@johncowen johncowen added the theme/ui Anything related to the UI label Jan 25, 2021
@johncowen johncowen requested a review from kaxcode January 25, 2021 10:17
@vercel
Copy link

vercel bot commented Jan 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

consul-ui-staging – ./ui

🔍 Inspect: https://vercel.com/hashicorp/consul-ui-staging/g0v1zx4b8
✅ Preview: Failed

[Deployment for a802a42 failed]

Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@johncowen johncowen merged commit 08230a1 into ui/feature/services-filter-by Jan 25, 2021
@johncowen johncowen deleted the ui/feature/sub-filter-by branch January 25, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants