π§ͺ [Spike] Theming βsupportβ in HDS and Showcase - Designers' playground #2608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¨ DO NOT MERGE π¨
π Summary
Branch used as playground for the HDS designers so they can play with the design tokens for the HDS Components and the themed variables for the Showcase app.
π§βπ» What can be tested/experimented
package/tokens/src/
JSON files, to match the values in Figma, and see them applied to the HDS components in the showcasepackages/tokens/src/global/themed/[light|dark]/color/*.json
files, which contain the low-level tokens, then aliased to semantic and component-level tokensshowcase/app/styles/showcase-theming/[light|dark].scss
files, where you can find the few color tokens used in the showcase (they're declared in a Sass mixin)π§ How to run the code locally
To make the changes to the HDS source tokens and see them reflected in the showcase pages, you need three active CLI tabs:
Initial setup
In a CLI:
First tab β compilation of the source tokens
In a CLI:
this will automatically compile the design tokens from the
src
folder to thedist
folder, whenever a JSON file insrc
is changed.Second tab β compilation of the HDS components CSS file
In a CLI:
this will automatically re-generate the CSS for the components, consumed in the showcase app
Third tab β compilation of the showcase
In a CLI:
this will automatically re-compile the showcase app, with the new design tokens, and automatically refresh the open window (at
http://localhost:4200
if you're using the standard port, otherwise you can use the--port
argument in the command, and this will use the specified port).π External links
Jira tickets: