SuperSelect - search position (HDS-4254)
#2612
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/components/src/components/hds/form/super-select/single/base.hbs
Show resolved
Hide resolved
| @@ -59,6 +59,7 @@ | |||
| @search={{@search}} | |||
| @searchEnabled={{@searchEnabled}} | |||
| @searchField={{@searchField}} | |||
| @searchFieldPosition={{@searchFieldPosition}} | |||
There was a problem hiding this comment.
Ultimately, we most likely will want to hard code the searchFieldPosition value to "before-options" but I will do some testing within consumer products to see if we could release with that initially or if a phased release approach is better.
There was a problem hiding this comment.
I added the results of testing in the ticket: https://hashicorp.atlassian.net/browse/HDS-4254
To me, it seems fairly safe to hard-code the value as "before-options" for release. We could perhaps post in Slack channels to double-check with consumers first though and give them a heads-up about the change.
There was a problem hiding this comment.
If tests are not failing, and it seems like they aren't, we can safely hard-code it. Indeed, a good idea to give folks a heads-up about the change in our public channel.
…add preliminary Showcase examples
KristinLBradley
force-pushed
the
hds-4254-super-select-search-position
branch
from
cd56538 to
50080f9
Compare
…Multiple SuperSelect, clean up Showcase
KristinLBradley
changed the title
SuperSelect - search position (HDS-4254)SuperSelect - search position (HDS-4254)
|
|
||
| `SuperSelect` updates including: | ||
| - Updated `ember-power-select` from `8.2.0` to `8.6.0` | ||
| - Added `searchFieldPosition="before-options"` to fix a11y issue in `Multiple` component |
There was a problem hiding this comment.
How is this?
There was a problem hiding this comment.
Looks good! We can elaborate on the visual impact in Slack and the release email
📌 Summary
If merged, this PR adds the
searchFieldPositiontoSuperSelectenablingSuperSelect::Multipleto display the search field within the before options area instead of in the trigger area.Related:
SuperSelect- docs for search position (HDS-4254) #2620🛠️ Detailed description
searchFieldPositionargument to SuperSelect components📸 Screenshots
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.