Upgrade Nodejs to 22 #2619
Open
Upgrade Nodejs to 22 #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dhaulagiri
reviewed
Dec 20, 2024
| @@ -330,6 +330,6 @@ | |||
| "dist" | |||
| ], | |||
| "engines": { | |||
| "node": "16.* || >= 18" | |||
| "node": ">= 18" | |||
There was a problem hiding this comment.
@alex-ju I'm curious your opinion on this. Technically this should be considered a breaking change, but AFAICT we don't have any known consumers using Node 16. On the other hand, there is no real need for us to make this change either.
There was a problem hiding this comment.
According to the latest findings around the API our consumers are mostly concerned about the changes not affecting them, rather than following a rigid versioning policy. Based on this, and considering Ember dropped support for Node 16 in v5.11.0, so I'd say we can do it in a minor release too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
16* || >= 18to>=1820.xto the latest LTS of22.x🛠️ Detailed description
Removing support for Node.js 16 due to the following factors
>18>=18.12.0🔗 External links
Jira ticket: HDS-4265
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.