Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Limit retries for network level failures #1087

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

jackofallops
Copy link
Member

  • add support for limiting retries for network level failures such as tcp dial timeouts

This PR updates handling of retries for network failures that are unlikely to recover in a reasonable timeframe (for example the client being behind a firewall silently dropping packets, or an un-routable address), specifically on GET, HEAD and OPTIONS requests, which would otherwise repeat endlessly until a parent context expired.

@jackofallops jackofallops requested a review from a team as a code owner October 1, 2024 10:15
@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Oct 1, 2024
bump go version as GHA downloading updated Go every run.
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops LGTM 🦭

sdk/client/client.go Outdated Show resolved Hide resolved
@jackofallops jackofallops merged commit 9b08015 into main Oct 21, 2024
5 checks passed
@jackofallops jackofallops deleted the b/client-network-error-retry-handling branch October 21, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants