Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Support MSI authentication in Azure Container App and App Service like environments #1093

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

vermacodes
Copy link

@vermacodes vermacodes commented Oct 9, 2024

Fixes #1054

Pull Request: Enhanced Support for Azure App Service Like Environments

This pull request updates managed_identity_authorizer.go to improve support for Azure App Service like environments. Key changes include:

  • Environment Check: Now checks for MSI_ENDPOINT and MSI_SECRET environment variables to detect App Service like environments.
  • MSI Endpoint Update: Uses MSI_ENDPOINT as the default instead of the well-known endpoint.
  • API Version Change: Switches to the 2019-08-01 API version, which requires the IDENTITY_HEADER in the HTTP request.
  • Endpoint Override: Users can still override the default endpoint if needed.

These changes ensure better compatibility with Azure's managed identity in App Service like environments.

@vermacodes vermacodes requested a review from a team as a code owner October 9, 2024 18:02
Copy link

hashicorp-cla-app bot commented Oct 9, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Oct 9, 2024
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@hen-den
Copy link

hen-den commented Oct 10, 2024

This is awesome for the last months we had to use a proxy to rewrite the endpoint versions. Great work.

@vermacodes
Copy link
Author

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

This has been signed, not sure why its not updating.

@kabal2010
Copy link

@vermacodes
Nice one. Will really love this pushed to production as this has been a blocker running Terraform on Azure Container Apps when authenticating with Managed Identity

@vermacodes vermacodes changed the title Support MSI authentication in Azure Container App and App Service like environments SDK - Support MSI authentication in Azure Container App and App Service like environments Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support api-version 2019-08-01 or above for Azure Container App
3 participants