Removed ova file type from the list of supported decompressors #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point, LGTM, it would be nice if we could say |
This was referenced Mar 22, 2022
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes ova files from the list of files to decompress upon downloading. Support for decompressing ova files was added in #351. Which has caused a regression in the Virtualbox plugin for Packer hashicorp/packer#11631.
Thinking about ova files, I wouldn't expect go-getter to treat them as a tarball but instead as a single file to be consumed downstream. An alternative to removing ova from the list of decompressors would be to add the archive=false query parameter to the source path in the Virtualbox plugin (possibly other plugins as well). But I opted not to go that route because the decompressing of ova files seems like an expected behavior.
If having the ova file extension listed as a decompressor is necessary then we may want to consider adding a separate decompressor type with updated logic specifically for ova files, possibly in a minor release.