Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iterate lower bound may panic if search with the same prefix on keys #35

Closed

Conversation

absolute8511
Copy link

this should fix the issue #28

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 25, 2021

CLA assistant check
All committers have signed the CLA.

@absolute8511 absolute8511 changed the title fix: iterator lower bound may panic if search with the same prefix on keys fix: iterate lower bound may panic if search with the same prefix on keys Feb 25, 2021
@banks
Copy link
Member

banks commented Jun 17, 2021

Thanks you so much @absolute8511 for this PR.

I've included fixes for these panics as part of fixing a bunch of other bugs in #39. One of those other fixes is the same panic bug that exists in SeekReverseLowerBound too.

I'll close this PR in favour of the more complete one, but your effort in finding and fixing this with tests is very much appreciated, Thank you!

@banks banks closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants