Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce MemDB.DBSchema() method for introspection #121

Merged
merged 2 commits into from
Mar 14, 2022
Merged

introduce MemDB.DBSchema() method for introspection #121

merged 2 commits into from
Mar 14, 2022

Conversation

radeksimko
Copy link
Member

This is to support more straightforward integration with a UI, also mentioned in #57

kisunji
kisunji reviewed Mar 11, 2022
View reviewed changes
memdb.go Show resolved Hide resolved
mitchellh
mitchellh reviewed Mar 11, 2022
View reviewed changes
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend docs on the function but otherwise LGTM.

@radeksimko radeksimko requested review from mitchellh and kisunji March 11, 2022 19:04
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@radeksimko radeksimko merged commit 96a58bd into main Mar 14, 2022
@radeksimko radeksimko deleted the f-db-schema-method branch March 14, 2022 16:35
@manhdaovan manhdaovan mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisunji kisunji kisunji approved these changes

@mitchellh mitchellh Awaiting requested review from mitchellh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radeksimko @hashicorp-cla @mitchellh @kisunji