Start the plugin using the configured stdin, if available #127
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the command client had a stdin already configured, use that instead of os.stdin when starting the plugin.
|
|
carolynvs
pushed a commit
to carolynvs/porter
that referenced
this pull request
Oct 25, 2019
carolynvs
pushed a commit
to carolynvs/porter
that referenced
this pull request
Oct 28, 2019
carolynvs
pushed a commit
to getporter/porter
that referenced
this pull request
Oct 29, 2019
* Use a patch of hashicorp/go-plugin hashicorp/go-plugin#127 * Sync vendor * Pass plugin config via stdin
|
Any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
When the
Cmdstruct already hasstdinalready configured, use that instead ofos.Stdinwhen starting a plugin.Why?
I wanted to pass data to my plugins to assist with initialization, passing one-time configuration data that isn't part of the interface used to communicate with the plugin. I was having trouble getting this sent properly via
os.Stdinhonestly... 😊This seems like an improvement because it doesn't require remembering the original
os.Stdinand swapping it back, and makes it easier for the host to pass a different stdin to a plugin, or mock it out for a test.