Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update client.go #260

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update client.go #260

wants to merge 3 commits into from

Conversation

hmzzrcs
Copy link

@hmzzrcs hmzzrcs commented Jul 5, 2023

Allow user to send something by cmd.Stdin

Allow user to send something by cmd.Stdin
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 5, 2023

CLA assistant check
All committers have signed the CLA.

add test case for stdin
Copy link

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style comments

Comment on lines 821 to +822
}
func TestClient_StdinBuffer(t *testing.T) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
func TestClient_StdinBuffer(t *testing.T) {
}
func TestClient_StdinBuffer(t *testing.T) {

Comment on lines +849 to 850
}
func TestClient_SecureConfig(t *testing.T) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
func TestClient_SecureConfig(t *testing.T) {
}
func TestClient_SecureConfig(t *testing.T) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants