Allow more mtls curve #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new configuration option `AutoMTLSCurve` to allow users to specify the elliptic curve used in generating the certificate and private key for AutoMTLS. This improves the extensibility of the project. The default curve is `elliptic.P521`.
|
The limitation of python-grpcio only supporting the P256 curve, since fixed by grpc/grpc#34867, means that the Python protocol plugin service can communicate properly with the Go Client using AutoMTLS as of grpc's next release version, without specifying the curve type. Therefore, this pull request may not be as urgent or necessary as before, while it still provides some flexibility for future extensions. Please let me know if you have any questions or feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the limitation of
python-grpcio, which only supports the P256 elliptic curve(grpc/grpc#23235), when AutoMTLS is enabled, the Python protocol plugin service cannot communicate properly with the Go Client.Therefore, I have added the 'AutoMTLSCurve' option to allow specifying the curve type independently for AutoMTLS in the Client and Server. This will facilitate future extensions.