Modify go_package to a full path in plugin's proto #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes is friendly for bazel to avoid from the error “missing strict dependencies” .
When I used bazel build to build exe file, I encountered the error：
compilepkg: missing strict dependencies:
/private/var/tmp/_bazel_kk/43cdc04641453be2515122d57e93f7eb/sandbox/darwin-sandbox/1312/execroot/_main/external/gazelle
go_deps~com_github_hashicorp_go_plugin/grpc_broker.go: import of "github.com/hashicorp/go-plugin/internal/plugin"go_deps/private/var/tmp/_bazel_kk/43cdc04641453be2515122d57e93f7eb/sandbox/darwin-sandbox/1312/execroot/_main/external/gazelle
com_github_hashicorp_go_plugin/grpc_client.go: import of "github.com/hashicorp/go-plugin/internal/plugin"com_github_hashicorp_go_plugin/grpc_controller.go: import of "github.com/hashicorp/go-plugin/internal/plugin"/private/var/tmp/_bazel_kk/43cdc04641453be2515122d57e93f7eb/sandbox/darwin-sandbox/1312/execroot/_main/external/gazelle~~go_deps
/private/var/tmp/_bazel_kk/43cdc04641453be2515122d57e93f7eb/sandbox/darwin-sandbox/1312/execroot/_main/external/gazelle
go_deps~com_github_hashicorp_go_plugin/grpc_server.go: import of "github.com/hashicorp/go-plugin/internal/plugin"go_deps~com_github_hashicorp_go_plugin/grpc_stdio.go: import of "github.com/hashicorp/go-plugin/internal/plugin"/private/var/tmp/_bazel_kk/43cdc04641453be2515122d57e93f7eb/sandbox/darwin-sandbox/1312/execroot/_main/external/gazelle
No dependencies were provided.
The reason is that the go_package be set to relative path, and bazel can not identify it.
Though these maybe are the issues of bazel, using full path in golang is common too. So I pull this request.