Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#TF-15258] add manage-agent-pools to team organization access #901

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

emlanctot
Copy link
Contributor

@emlanctot emlanctot commented May 14, 2024

Description

This PR adds new ManageAgentPools permission to team organization access.

Testing plan

  • ManageAgentPools is false by default when Teams are created.
  • ManageAgentPools is read for Teams.
  • ManageAgentPools should be updatable through the OrganizationAccessOptions.

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" go test ./... -v -run TestFunctionsAffectedByChange

...

@emlanctot emlanctot force-pushed the el/add_manage_agent_pools_to_org_access branch from 5d584d4 to 0a5373a Compare June 6, 2024 21:24
@emlanctot emlanctot marked this pull request as ready for review June 6, 2024 21:26
@emlanctot emlanctot requested a review from a team as a code owner June 6, 2024 21:26
@emlanctot emlanctot requested a review from a team June 6, 2024 21:26
Copy link
Contributor

@juliannatetreault juliannatetreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🌟

@emlanctot emlanctot merged commit e20eabe into main Jun 11, 2024
8 checks passed
@emlanctot emlanctot deleted the el/add_manage_agent_pools_to_org_access branch June 11, 2024 17:18
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants