Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Automate releasing via bob #99

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Feb 2, 2023

Context

Releasing currently requires a number of additional steps outside of GitHub. For a simple project with simple release pipeline such as this one, there is no strong benefit to do multi-staged releasing, as some other bigger projects do.

Proposal

Simplify release process by moving promotion steps into a GHA workflow.

TODO

  • Create a dedicated GH bot account with appropriate access
  • Grant access for proj-terraform-exec-bot to bob repo
  • Generate new PAT within the GH bot account ^
  • Set PAT as a new secret within this repo BOB_GITHUB_TOKEN
  • Update release docs

@radeksimko radeksimko self-assigned this Feb 2, 2023
@radeksimko radeksimko mentioned this pull request Feb 2, 2023
3 tasks
@kmoe
Copy link
Member

kmoe commented Mar 31, 2023

Is there a way to have the CLI binaries attached to the GitHub release?

@radeksimko
Copy link
Member Author

radeksimko commented Mar 31, 2023

Is there a way to have the CLI binaries attached to the GitHub release?

Not directly through CRT (at least not currently), we'd have to build our own workflow to do that.

I'm not sure it's worth uploading it there though, for a couple of reasons:

  1. Integrity checking would be quite a manual process (unless someone builds a script around it), which increases the risk folks just wouldn't do it, which then compromises any integrity checking hc-install would do when installing other products. This is also why go install method is discouraged, as that faces the same problem, unless you're careful enough to specify an exact version and hash. Linux package managers and Homebrew do the integrity checking by default.
  2. We'd end up spreading our download stats between GitHub and releases.hashicorp.com, where each has different methodology, granularity etc. so getting an accurate stats would be much more difficult.

@radeksimko radeksimko requested a review from kmoe July 31, 2023 14:11
@radeksimko radeksimko marked this pull request as ready for review July 31, 2023 14:11
@radeksimko radeksimko merged commit 9bbc98c into main Dec 6, 2023
10 checks passed
@radeksimko radeksimko deleted the ci-automate-bob-releasing branch December 6, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants