Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printer, scanner: Don't produce unparsable output. #241

Merged
merged 3 commits into from
Mar 20, 2018
Merged

printer, scanner: Don't produce unparsable output. #241

merged 3 commits into from
Mar 20, 2018

Commits on Mar 20, 2018

  1. printer: Add unit test of Format() producing unparsable output.

    @octo
    octo committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    a81aa7b View commit details
    Browse the repository at this point in the history

  2. scanner: Report null bytes as errors, even at the end of file. 

    The formatter will append a newline at the end of file, causing the output
of printer.Format() to be invalid.
    @octo
    octo committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    a5efd34 View commit details
    Browse the repository at this point in the history

  3. scanner: Fail if U+E123 is found in input. 

    This (invalid) Unicode codepoint is used by the printer package to fix up
the indentation of generated files. If this codepoint is present in the
input, the package gets confused and removes more than it should,
producing unparsable output.
    @octo
    octo committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    ec2ba18 View commit details
    Browse the repository at this point in the history