Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hclwrite: Fix formatting of namespaced functions #658

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Conversation

radeksimko
Copy link
Member

Before

echo 'attr = provider::framework::example()' | terraform fmt -
attr = provider :: framework :: example()

After

echo 'attr = provider::framework::example()' | terraform fmt -
attr = provider::framework::example()

@radeksimko radeksimko added the bug label Feb 15, 2024
@radeksimko radeksimko requested a review from a team February 15, 2024 15:46
@radeksimko radeksimko requested review from DanielMSchmidt and a team and removed request for DanielMSchmidt February 15, 2024 16:04
hclwrite/format.go Outdated Show resolved Hide resolved
Copy link
Contributor

@apparentlymart apparentlymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me.

My inline comment is about a little mess that go fmt seems to have made of one of the older comments, which of course isn't directly related to what you were doing in this PR but if possible it would be nice to avoid making that comment harder to read.

@radeksimko radeksimko merged commit a7f9ab5 into main Feb 16, 2024
7 checks passed
@radeksimko radeksimko deleted the b-fix-func-fmt branch February 16, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants