Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve browser login #265

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Improve browser login #265

merged 4 commits into from
Aug 23, 2024

Conversation

ohm
Copy link
Contributor

@ohm ohm commented Aug 20, 2024

🛠️ Description

Addressing feedback received in hashicorp/hcp#139:

  • print the full auth URL instead of the configured base URL
  • optionally open a browser window to accommodate cases where the default browser isn't the desired browser

This will be followed up in https://github.com/hashicorp/hcp to configure the browser login.

🔗 External Links

👍 Definition of Done

  • SDK added
  • SDK updated
  • Tests added?
  • Docs updated?

Copy link

hashicorp-cla-app bot commented Aug 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@ohm ohm force-pushed the ohm/auth-url branch 2 times, most recently from ebe9b71 to 1be49d6 Compare August 22, 2024 08:42
config/with.go Show resolved Hide resolved
@ohm ohm merged commit 050fedb into main Aug 23, 2024
3 checks passed
@ohm ohm deleted the ohm/auth-url branch August 23, 2024 12:40
@ohm ohm mentioned this pull request Aug 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants