Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow and README.md tweaks #44

Merged
merged 4 commits into from
May 25, 2022
Merged

Workflow and README.md tweaks #44

merged 4 commits into from
May 25, 2022

Conversation

magnetikonline
Copy link
Contributor

While working on #43 - noted a few little tweaks/fixes that could be made:

  • Bump GitHub Actions to @v3 variants and add consistent name:'s to each job step.
  • Give a friendly workflow name to publish.yml.
  • Add workflow status badges to README.md.
  • A little spit and shine to .gitignore.
  • A few random README.md rewrites.

jpogran
jpogran requested changes May 18, 2022
View reviewed changes
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help with the documentation! Once the inline style requests are addressed this will be good to go.

.gitignore Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
@magnetikonline
Copy link
Contributor Author

Hey @jpogran - thx for the considered review 👍 I think i've addressed all the comments. 😄.

Ready for re-review.

@jpogran jpogran merged commit 4a60084 into hashicorp:main May 25, 2022
@magnetikonline
Copy link
Contributor Author

Thanks @jpogran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpogran jpogran jpogran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnetikonline @jpogran