feat: support nextjs v12 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kirill-kruchkov
force-pushed
the
feat/support-next-12
branch
from
7822f15
to
2043b47
Compare
|
Thanks for the contribution! It looks like it will, but just confirming, will this change work fine on older versions of next? |
|
Hello @BRKalow! I think it should, but let me test it again in the evening. |
kirill-kruchkov
force-pushed
the
feat/support-next-12
branch
from
2043b47
to
6175271
Compare
kirill-kruchkov
force-pushed
the
feat/support-next-12
branch
from
6175271
to
140b51c
Compare
|
@BRKalow I created a separate branch that includes this change while using Next v10. I haven't noticed anything unusual, but I'm not familiar well enough with all the test cases (there're 4 test scripts in the package.json). Would be great if someone could double check it: https://github.com/kirill-kruchkov/next-remote-watch/tree/test/next-10. Also, I realised that this repo uses npm (I used yarn at first), so I updated this PR accordingly (dropped |
This was referenced Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextJS v12 requires a
hostnameandportto be provided for the custom server when a middleware is used in the project (https://nextjs.org/docs/advanced-features/custom-server). Updating NextJS breaks such a project's dev server, if it usesnext-remote-watch@1.0.0. Here's an example:This PR updates NextJS as a devDependency (not a peerDependency) of
next-remote-watchand addresses the aforementioned issue by:HOSTNAMEalongside thePORTfrom env variables.localhost).next(...)options.It also adds a middleware to test this behaviour.