Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add percy tests #17157

Merged
merged 1 commit into from
May 12, 2023
Merged

chore: add percy tests #17157

merged 1 commit into from
May 12, 2023

Conversation

ChaiWithJai
Copy link
Contributor

Closes #17129

@ChaiWithJai ChaiWithJai requested a review from philrenaud May 11, 2023 12:46
@github-actions
Copy link

Ember Asset Size action

As of 1333dfa

Files that stayed the same size 🤷‍:

File raw gzip
nomad-ui.js 0 B 0 B
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

main 1333dfa change
passes 1495 1495 0
failures 4 4 0
flaky 0 0 0
duration 000ms 000ms -000ms

philrenaud
philrenaud approved these changes May 12, 2023
View reviewed changes
ui/tests/acceptance/job-definition-test.js
await Definition.visit({ id: 'not-a-real-job' });
await percySnapshot(assert);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I think this is the one taking the snapshot of the error page discussed earlier

@ChaiWithJai ChaiWithJai merged commit 17633d8 into main May 12, 2023
@ChaiWithJai ChaiWithJai deleted the 17129/percy branch May 12, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrenaud philrenaud philrenaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui] Percy Snapshots for HCL in UI
2 participants
@ChaiWithJai @philrenaud