Don't set OSProfile (Username/password) on images that use a Specialized Parent #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenGoldstrich
force-pushed
the
dont_set_osprofile_for_specialized_sourced_builds
branch
from
4ac92ab
to
facd28e
Compare
JenGoldstrich
commented
Jul 5, 2023
| // First a parent Specialized ARM 64 Linux VM to a Shared Image Gallery/Compute Gallery | ||
| // Then a second Specialized ARM64 Linux VM that uses the first as its source/parent image | ||
| func TestBuilderAcc_SharedImageGallery_ARM64SpecializedLinuxSIG_WithChildImage(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
Tests can run a LOT faster if we just parallelize them all!
nywilken
reviewed
Jul 6, 2023
| @@ -517,6 +516,15 @@ func (s *TemplateBuilder) SetSecurityProfile(secureBootEnabled bool, vtpmEnabled | |||
| return nil | |||
| } | |||
|
|
|||
| func (s *TemplateBuilder) SetSpecializedVM() error { | |||
| resource, err := s.getResourceByType(resourceVirtualMachine) | |||
There was a problem hiding this comment.
Do we need to validate the the virtualMachine has the specialized property set?
nywilken
reviewed
Jul 6, 2023
…zed compute gallery image as a source
…ild a child image
…key for linux SIG builds
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
JenGoldstrich
force-pushed
the
dont_set_osprofile_for_specialized_sourced_builds
branch
from
6b00da6
to
af090b4
Compare
nywilken
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Code wise this looks good go me. But I learned that I could only get the acceptance test to pass if I used an RSA key. I then found https://learn.microsoft.com/en-us/troubleshoot/azure/virtual-machines/ed25519-ssh-keys
Maybe that should be part of the description for the env var. Or call rename to ARM_SSH_RSA_KEY_FILE
JenGoldstrich
deleted the
dont_set_osprofile_for_specialized_sourced_builds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue added with plugin version v1.4.3
Description
In that plugin version we added support for creating a specialized ACG image with Packer, however when trying to use that specialized ACG image as a source for another image, we would incorrectly set the username and password, which is already defined in non-generalized VM Images.
Changes
ARM_SSH_PRIVATE_KEY_FILECloses #307