Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port DTL Builder and Provisioner To The New SDK #318

Closed
wants to merge 30 commits into from
Closed

Port DTL Builder and Provisioner To The New SDK #318

wants to merge 30 commits into from

Conversation

JenGoldstrich
Copy link
Contributor

Untested

still need to add VMID

JenGoldstrich and others added 30 commits July 6, 2023 20:19
@JenGoldstrich
Rebasing entire ARM builder migration on top of main
2c1a5ca
@JenGoldstrich
Remove some missed old SDK stuff, including the autorest To package f…
1713fc7 
…rom ARM Builder
@JenGoldstrich
Update oidc-example.json
9184d51
@JenGoldstrich
Pass SIG ID subscription through to state
7e9b787
@JenGoldstrich
Use Hamilton MSGraph SDK to fetch Object ID for Windows builds
124d0f3
@JenGoldstrich
Format and add comment
14d6343
@JenGoldstrich
commit generated code
e5e0ee4
@JenGoldstrich
Switch AuthType back to private variable and use helper function to g…
ce78b51 
…et it, switch from MeClient to ServicePrincipals client to get objectID
@JenGoldstrich
Print MSgraph error again
1152c55
@JenGoldstrich
Don't use Hamilton, get it from the Access Token
7eeed22
@JenGoldstrich
fmt and pass in correct context on cleanup
ad028f7
@JenGoldstrich
Mess with backoff time while testing to see if this can be a bit smoo…
9483a6b 
…ther of a process for users
@JenGoldstrich
Don't use context.TODOs in ARM Builder client calls
0d3d611
@JenGoldstrich
Update with newest cty fork
547982a
@JenGoldstrich
Use hcl file in oidc test
ccc0de7
@JenGoldstrich
Use Giovanni instead of Blob Container serivce
c66904a
@JenGoldstrich
Implement new SDK environment logic
74b07aa
@JenGoldstrich
Address fmt
9457e49
@JenGoldstrich
Remove unused function, go mod tidy
f083829
@JenGoldstrich
v2
2317330
@JenGoldstrich
Switch to forked release process
926b872
@JenGoldstrich
Azure Germany was shutdown in 2021
9701464
@JenGoldstrich
Remove Template Capture from ARM Builder, this work will need to be r…
eebd456 
…eplicated to DTL/Chroot
@JenGoldstrich
Fail fast: Check if a SIG Destination Image Version exists before try…
9241015 
…ing to create it
@JenGoldstrich
Implement Lucas's feedback
7a2ae67
@JenGoldstrich
Make generate
4db57fc
@JenGoldstrich
Start DTL builder work
0a456d1
@JenGoldstrich
DTL almost done! Just need to get VMID instead of capture template me…
e0ca255 
…thod and start testing
@JenGoldstrich
Port DTL provisioner to new SDK
f9938b9
@JenGoldstrich
Make generate
be92155
@JenGoldstrich JenGoldstrich requested a review from a team as a code owner July 7, 2023 03:30
@JenGoldstrich JenGoldstrich marked this pull request as draft July 7, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JenGoldstrich