[V2] Use PFX Certificates for Client Auth instead of PEM #327 #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenGoldstrich
added
breaking-change
version/bump major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #327
In the new SDK we are using in v2 client certificates behave the way they do for the Terraform Provider https://registry.terraform.io/providers/hashicorp/azuread/latest/docs/guides/service_principal_client_certificate using .pfx files only. This also allows user to use password protected certificates which is preferred for security. This will require users to generate new certificates sadly which is a breaking change
Adds client_cert_password field, as most pfx files are password protected and the SDK supports this
Removes client_cert_timeout field, which is not supported in the new SDK
This PR has a messy diff since its on top of my fork with all of V2 migration, but the main changers are in the azure_authorizer file, and in the common client config
Closes #46