Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_shallow_replication field for Compute Gallery/SIG builds, fix replica count type #337

Merged
merged 6 commits into from
Oct 17, 2023

Commits on Oct 16, 2023

  1. Add use_shallow_replication option for SIG image versions & Cast re…

    …plica count at int64 to fix it being parsed as the wrong number
    
    Fix sig replica count - use shallow replication in acc test - fix units
    
    Make generate
    
    Add tests
    
    Update docs-partials/builder/azure/arm/SharedImageGalleryDestination-not-required.mdx
    
    Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
    
    Update builder/azure/arm/step_publish_to_shared_image_gallery.go
    
    Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
    
    Implement the rest of Wilken's suggested changes
    
    Add validation, fix acceptance tests with new name for shallow replication field
    
    make generate
    
    Fix make generate
    
    Fix make generate after rebasing on main
    
    Add comments and tests
    JenGoldstrich committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    c5fdc78 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Apply suggestions from code review

    Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
    JenGoldstrich and nywilken authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    a5e0c5c View commit details
    Browse the repository at this point in the history
  2. Update builder/azure/arm/step_publish_to_shared_image_gallery.go

    Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
    JenGoldstrich and nywilken authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    e413c14 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2d3f35a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4044fa3 View commit details
    Browse the repository at this point in the history
  5. Shallow Replication region check didn't work so I changed it to be a …

    …bit simpler, be stricter about requiring replica count = 1 rather than > 1 for shallow replication
    JenGoldstrich committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9a58704 View commit details
    Browse the repository at this point in the history