Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip_build_key_vault_create to skip build Keyvault create during window builds #393

Merged
merged 12 commits into from
May 22, 2024
Merged

Add skip_build_key_vault_create to skip build Keyvault create during window builds #393

merged 12 commits into from
May 22, 2024

Commits on Mar 14, 2024

  1. Add skip_create_build_key_vault

    @garimakhulbe02
    garimakhulbe02 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    38eeb85 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Merge pull request #1 from garimakhulbe02/garima-msft-skipbuildkv 

    Add skip_create_build_key_vault
    @garimakhulbe02
    garimakhulbe02 authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3f224e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. added context in readme

    @garimakhulbe02
    garimakhulbe02 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    d95098b View commit details
    Browse the repository at this point in the history

  2. make generate

    @garimakhulbe02
    garimakhulbe02 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    6929f97 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Jenna's edits: Add basic example, adjust config comment and run make … 

    …generate
    @JenGoldstrich
    JenGoldstrich committed May 21, 2024
    Configuration menu
    Copy the full SHA
    dd2cd40 View commit details
    Browse the repository at this point in the history

  2. Remove accidental merge markers

    @JenGoldstrich
    JenGoldstrich committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7331080 View commit details
    Browse the repository at this point in the history

  3. Add working windows 11 example

    @JenGoldstrich
    JenGoldstrich committed May 21, 2024
    Configuration menu
    Copy the full SHA
    37f1407 View commit details
    Browse the repository at this point in the history

  4. Update docs

    @JenGoldstrich
    JenGoldstrich committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a209945 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com>
    @JenGoldstrich @lbajolet-hashicorp
    JenGoldstrich and lbajolet-hashicorp authored May 22, 2024
    Configuration menu
    Copy the full SHA
    8902bea View commit details
    Browse the repository at this point in the history

  2. Update builder/azure/arm/config.go 

    Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com>
    @JenGoldstrich @lbajolet-hashicorp
    JenGoldstrich and lbajolet-hashicorp authored May 22, 2024
    Configuration menu
    Copy the full SHA
    8d0fc60 View commit details
    Browse the repository at this point in the history

  3. Lucas's feedback, use -SkipNetworkProfileCheck

    @JenGoldstrich
    JenGoldstrich committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a1b1782 View commit details
    Browse the repository at this point in the history

  4. make generate after Lucas's PR feedback

    @JenGoldstrich
    JenGoldstrich committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e4f6528 View commit details
    Browse the repository at this point in the history