Fix panic when encrypted images or using security type with a Shared Image Gallery source #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with SIG Sourced Images
JenGoldstrich
changed the title
JenGoldstrich
commented
Apr 16, 2024
| @@ -748,6 +748,41 @@ func TestTrustedLaunch01(t *testing.T) { | |||
| approvaltests.VerifyJSONStruct(t, deployment.Properties.Template) | |||
| } | |||
|
|
|||
| func TestSigSourcedWithDiskEncryptionSet(t *testing.T) { | |||
There was a problem hiding this comment.
These two tests panic without the changes to template_builder.go to validate the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we weren't instantiating the managed image object inside the template factory whenever a build used a SIG image as a source, (i.e. had a shared_image_gallery block set), this would cause a panic when setting a disk encryption set ID, and as of v2.0.5. it would also cause a similar panic when trying to set the encryption type. To verify this I went back to version 2.0.0 and also reproduced a panic when setting a disk encryption set ID with a
shared_image_galleryblock as the source imageTo fix this I just added nullchecks and instantiate where relevant, I ran acceptance tests on this PR
Closes #406