Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Subscription ID and Tenant ID to build variables #439

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

JenGoldstrich
Copy link
Contributor

This can be helpful when subscription ID and tenant ID aren't explicitly set already in the template/env variables due to CLI auth/other login methods.

Closes #436

@JenGoldstrich JenGoldstrich requested a review from a team as a code owner August 23, 2024 00:34
@JenGoldstrich JenGoldstrich marked this pull request as draft August 23, 2024 00:34
@JenGoldstrich JenGoldstrich marked this pull request as ready for review August 23, 2024 01:07
@JenGoldstrich JenGoldstrich force-pushed the add-sub-and-tenant-to-generated-data branch 2 times, most recently from e35d6c7 to d1a238f Compare August 23, 2024 01:17
@JenGoldstrich JenGoldstrich force-pushed the add-sub-and-tenant-to-generated-data branch from d1a238f to 916cb5a Compare August 23, 2024 01:17
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Nicely done.

@straubt1
Copy link
Contributor

Thank you @JenGoldstrich!
I did build and test this in my sandbox and worked a charm!

@JenGoldstrich JenGoldstrich merged commit e47bee8 into main Aug 23, 2024
12 checks passed
@JenGoldstrich JenGoldstrich deleted the add-sub-and-tenant-to-generated-data branch August 23, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packer Builds for Multiple Azure Tenants
3 participants