Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG #47

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Update CHANGELOG #47

merged 4 commits into from
Mar 31, 2021

Conversation

nywilken
Copy link
Contributor

No description provided.

@nywilken nywilken requested a review from a team as a code owner March 31, 2021 13:59
@nywilken nywilken added the tech-debt Issues and pull requests related to addressing technical debt or improving the codebase label Mar 31, 2021
CHANGELOG.md Outdated
Comment on lines 5 to 10
* commonsteps/http_config: Add `http_content` configuration option as an
alternative method for serving static HTTP content. This option works
similar to `http_directory` but has the ability to serve files that include
Go templating variables that can be interpolated at runtime by Packer core.
[[GH-43]()https://github.com/hashicorp/packer-plugin-sdk/pull/43]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

Suggested change
* commonsteps/http_config: Add `http_content` configuration option as an
alternative method for serving static HTTP content. This option works
similar to `http_directory` but has the ability to serve files that include
Go templating variables that can be interpolated at runtime by Packer core.
[[GH-43]()https://github.com/hashicorp/packer-plugin-sdk/pull/43]
* commonsteps/http_config: Add `http_content` configuration option as an
alternative method for serving static HTTP content. This option works
similar to `http_directory` but has the ability to serve files that include
Go templating variables that can be interpolated at runtime by Packer core.
[GH-43](https://github.com/hashicorp/packer-plugin-sdk/pull/43)

Also, #43 adds a didyoumean Package that could allow plugin maintainers to hint on things. I think it would be nice to document it too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops to late :p

Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

* add entry for didyoumean package
* Add note for backwards incompatibility introduced in v0.0.12
@nywilken nywilken merged commit d6236f9 into main Mar 31, 2021
@nywilken nywilken deleted the update-changelog-0.11 branch March 31, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants