Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang image to 1.16 #48

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Bump golang image to 1.16 #48

merged 1 commit into from
Apr 1, 2021

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Apr 1, 2021

No description provided.

@nywilken nywilken requested a review from a team as a code owner April 1, 2021 16:01
@nywilken nywilken added the tech-debt Issues and pull requests related to addressing technical debt or improving the codebase label Apr 1, 2021
sylviamoss
sylviamoss approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sdk is on 1.14 though. I'm wondering if that's a problem but I think is not. Our local env is on 1.16 and it ran well 👍🏼

@SwampDragons
Copy link
Contributor

we should bump it too.

@nywilken
Copy link
Contributor Author

nywilken commented Apr 1, 2021

Oh okay I will bump that as well. 🤞

@nywilken nywilken changed the title Bumpo golang image to 1.16 Bump golang image to 1.16 Apr 1, 2021
@nywilken nywilken merged commit 7990204 into main Apr 1, 2021
@nywilken nywilken deleted the bump-golang-ci branch April 1, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylviamoss sylviamoss sylviamoss approved these changes

Assignees
No one assigned
Labels
tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nywilken @SwampDragons @sylviamoss