Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store source image url that was actually used, for recordkeeping #84

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

SwampDragons
Copy link
Contributor

Stores the iso url that was actually used, in case there were several options. This will be useful for tracking image provenance in the HCP Packer registry, for iso builds. I need this information in the vsphere iso builder.

@SwampDragons SwampDragons requested a review from a team as a code owner October 7, 2021 21:03
Co-authored-by: Wilken Rivera <wilken@hashicorp.com>
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo but otherwise looks good. Once the change is made the test should pass. Approving so that you can merge when ready.

@SwampDragons SwampDragons merged commit 606325e into main Oct 7, 2021
@SwampDragons SwampDragons deleted the store_url branch October 7, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants