-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http_content func to serve variables from HTTP @ preseed #10801
Conversation
Codecov Report
|
@@ -1158,6 +1158,7 @@ var PASSTHROUGHS = map[string]string{"NVME_Present": "{{ .NVME_Present }}", | |||
"WinRMPassword": "{{ .WinRMPassword }}", | |||
"DefaultOrganizationID": "{{ .DefaultOrganizationID }}", | |||
"HTTPDir": "{{ .HTTPDir }}", | |||
"HTTPContent": "{{ .HTTPContent }}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this one was necessary but since HTTPDir
is there, I'm putting it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better be safe!
paste auto generated docs 🤷♂️
add `http_content` things
use http_content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Tested with virtualbox-iso building an alpine image and it worked!
Is this in a released version yet? Documentation doesn't seem to be live? Trying this with 1.7.2 locally doesn't seem to work? |
For anyone that gets here -- you have to add a front slash to your files, or things will not work.
^^^ this will not work!
This will. |
Hello there, thanks for adding this, a blog post is coming up ! I got tricked by the first slash a few times myself. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This imports hashicorp/packer-plugin-sdk#43
This helps with #9485