Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packer init doc fixes #12535

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Packer init doc fixes #12535

merged 2 commits into from
Jul 25, 2023

Conversation

lbajolet-hashicorp
Copy link
Contributor

Following up on #11541, this changes the wording of the positional argument for packer init, to make it more in line with validate and build, as they work similarly regarding the target.

This also adds a bit of information regarding the template/directory accepted as target for the command in the web docs.

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner July 24, 2023 18:30
`packer init' is meant to be invoked on a template file or a directory.
This was described in the command-line help message as
`[template.pkr.hcl|folder]'.

Because this is encapsulated between square brackets, this could be
taken as an option instead of a positional, mandatory argument.

This commit changes the wording to adopt a similar convention as `packer
build', so the two are consistent in how they are invoked, and to avoid
mistaking this argument as optional.
The `packer init' command's wording was not clear, so it was changed in
a preceding commit, and this commit aims to add more details on how the
command is meant to be used, along with a simple example.
@nywilken nywilken added backport/1.9.x Backport PR changes to `release/1.9.x` docs labels Jul 25, 2023
@lbajolet-hashicorp lbajolet-hashicorp merged commit 3922329 into main Jul 25, 2023
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the packer_init_doc_fixes branch July 25, 2023 20:45
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.9.x Backport PR changes to `release/1.9.x` docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants