circle-ci: add tests for windows and macos & test using go 1.13

[azr]

this should make our testing suite a little bit better and faster

fix #8035

[azr]

2019/09/05 06:37:26 Retryable error: open /Users/distiller/go/src/github.com/hashicorp/packer/common/net/packer_cache/port/1681: too many open files
--- FAIL: TestListenRangeConfig_Listen (0.51s)
panic: interface conversion: error is *os.PathError, not net.ErrPortFileLocked [recovered]
	panic: interface conversion: error is *os.PathError, not net.ErrPortFileLocked

goroutine 21 [running]:
testing.tRunner.func1(0xc000118200)
	/Users/distiller/go/src/testing/testing.go:874 +0x3a3
panic(0x18e4040, 0xc000431a10)
	/Users/distiller/go/src/runtime/panic.go:679 +0x1b2
github.com/hashicorp/packer/common/net.TestListenRangeConfig_Listen(0xc000118200)
	/Users/distiller/go/src/github.com/hashicorp/packer/common/net/configure_port_test.go:75 +0xf27
testing.tRunner(0xc000118200, 0x1a31528)
	/Users/distiller/go/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
	/Users/distiller/go/src/testing/testing.go:960 +0x350

Okay we have the #8035 issue in the darwin tests that are happening.

This is 'nice' because I can fix this using circle.

[azr]

Okay this is good to review; I always think I am are done when dealing with CI...

Basically we now run darwin + linux + windows tests on circle ci; I also changed the source of our fslock lib to point at mine ( github.com/azr/flock ) with a fix to that too many open files issue.

I think a file lock lib will be incorporated in a golang x/ pkg soonish. So we will remove that dep then.

[azr]

grabbing random build times:
darwin takes ~3m50 instead of ~13m3 on travis
windows takes ~6m18 instead of 6m20 on appveyor

[azr]

Okay; I'm merging this one because some other PRs need the fixes and I think it's safe enough 🙂

Let's open an issue if there's a problem !

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.