ci: use latest Go version and fix a flaky test #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Also remove module cache, because downloading from the module proxy is faster than using the cache.
It is not safe to call Fatalf from a goroutine because Fatalf calls runtime.Goexit which exits the current goroutine. That will not end the test when run from a different goroutine. Calling Errorf and returning does the right thing.
The test was not sleeping long enough, and was frequently missing the 'EventMemberFailed' event. By sleeping a bit logner this test seems to pass reliably.
dnephin
force-pushed
the
dnephin/update-ci
branch
from
1cd04fb
to
ac85eef
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove module cache, because downloading from the module proxy is faster than using the cache.