Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Switch from supervisord to systemd #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

craigday
Copy link

@craigday craigday commented May 7, 2019

No description provided.

Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

A few thoughts:

  1. How did you test this?
  2. Could you update the example Packer templates to use Amazon Linux 2?
  3. Could you update the docs to talk about systemd instead of supervisord?
  4. Remove sudo mkdir -p "$path/log" from the install script if we're not writing logs there anymore.
  5. Make stdout/stderr settings configurable.
  6. Please make sure to enable the service in systemd as shown in Enable systemd consul service terraform-aws-consul#135.

See https://github.com/hashicorp/terraform-aws-consul/pull/130/files for reference of a similar systemd switch that has examples of the above.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants