This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Fix missing snapshot id in ebs devices in nomad cluster #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brikis98
reviewed
May 12, 2020
If the volume_size is 0 then we assume that a snapshotid is available and use that one instead. AWS requires either a volume size or a snapshotid. It seems that Terraform filters a volume size of 0 out of the request to AWS.
brikis98
approved these changes
May 18, 2020
|
One test failed due to a timing / transient issue in the test code that is unrelated to this PR. Merging now, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the volume_size is 0 then we assume that a snapshotid is available and use that one instead.
AWS requires either a volume size or a snapshotid.
It seems that Terraform filters a volume size of 0 out of the request to AWS.
#63