-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(provider-generator): rename lambda namespace in lambda functions #1154
fix(provider-generator): rename lambda namespace in lambda functions #1154
Conversation
77f3871
to
cc5c9a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is fine with me as all resources belonging to the AWS Lambda Service are geared around Lambda Functions.
@skorfmann fine with you as well?
f08c856
to
a23a447
Compare
In python this lead a problem with importing this aws resource Closes #1152
a23a447
to
1a7cacf
Compare
Hm, the naming is a bit confusing.
Have you looked into the 2nd option mentioned by @jsteinich? |
I'm open for suggestions :)
I just took a look in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought a bit about it, and LambdaFunction
seems to be the best way right now. Per language renaming would lead to confusion in documentation and similar places. Also, haven't found a better name.
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
In python this lead a problem with importing this aws resource
Closes #1152