Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: (re)enable releasing via GitHub Action workflow #350

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jan 9, 2023

This follows a guide in https://github.com/hashicorp/signore/blob/main/docs/SIGNING_GIT_COMMITS.md and https://github.com/hashicorp/signore/blob/main/docs/SIGNING_IN_CI.md

TODO

  • register new bot GitHub account for holding new GPG key
  • update script to use new email
  • get a new signore signer
  • upload new pubkey to the bot GitHub account
  • ensure the correct SIGNORE_SIGNER is set
  • ensure the correct SIGNORE_CLIENT & SIGNORE_SECRET are set
  • Add release instructions to CONTRIBUTING.md

@radeksimko radeksimko added the ci label Jan 9, 2023
@radeksimko radeksimko force-pushed the ci-add-release-on-gha branch from 0358edd to 9b16b22 Compare January 10, 2023 11:17
@radeksimko radeksimko force-pushed the ci-add-release-on-gha branch 2 times, most recently from 85f6007 to 2caf27b Compare February 8, 2023 10:34
@radeksimko radeksimko force-pushed the ci-add-release-on-gha branch from 2caf27b to c838d2f Compare February 13, 2023 09:59
@radeksimko radeksimko marked this pull request as ready for review February 13, 2023 10:53
@radeksimko radeksimko requested review from kmoe and dbanck February 13, 2023 10:53
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I assume using git commit --gpg-sign="${SIGNORE_SIGNER}", removes the need to update the git config like outlined in the signore docs:

git config --global user.signingkey $your_signore_signer
git config --global commit.gpgsign true

@radeksimko
Copy link
Member Author

I assume using git commit --gpg-sign="${SIGNORE_SIGNER}", removes the need to update the git config like outlined in the signore docs:

Yes, that is my understanding as well. The git config options would mean "always sign every commit/tag", whereas we're just being more explicit there by passing the flags to git commit and git tag.

@radeksimko radeksimko merged commit e2f6be6 into main Feb 13, 2023
@radeksimko radeksimko deleted the ci-add-release-on-gha branch February 13, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants