Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfprotov5: Document Terraform 0.12-14 Requirement for UpgradeResourceStateResponse.UpgradedState.Msgpack #155

Closed
2 of 6 tasks
bflad opened this issue Feb 15, 2022 · 1 comment · Fixed by #156
Closed
2 of 6 tasks
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Feb 15, 2022

Does this documenation exist?

  • This is new documentation
  • This is an enhancement to existing documentation

Where would you expect to find this documentation?

  • On terraform.io
  • In the GoDoc for this module
  • In this repo as a markdown file
  • Somewhere else

Description

When running a protocol version 5 server via tf5server (or via tf6to5server), Terraform CLI 0.12 through 0.14 return an error such as:

    provider_test.go:11: Step 1/1 error: Error running post-apply plan: exit status 1
        
        Error: EOF

(Yes, that's it.) If UpgradeResourceState.Response.UpgradedState has the JSON field, but not Msgpack. We should document this requirement in the protocol version 5 definition and/or UpgradeResourceStateResponse type.

Discovered because terraform-plugin-framework only passes through the JSON field and ignores the Msgpack in its placeholder UpgradeResourceState handling.

References

@bflad bflad added the documentation Improvements or additions to documentation label Feb 15, 2022
@bflad bflad self-assigned this Feb 16, 2022
@bflad bflad added this to the v0.8.0 milestone Feb 16, 2022
bflad added a commit that referenced this issue Feb 16, 2022
…pgradeResourceStateResponse.UpgradedState.Msgpack

Reference: #155
bflad added a commit that referenced this issue Feb 17, 2022
…pgradeResourceStateResponse.UpgradedState.Msgpack (#156)

Reference: #155
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
1 participant